Skip to content

Add shortcut check for zero elements in af_write_array #3064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
avidov wants to merge 1 commit into from
Closed

Add shortcut check for zero elements in af_write_array #3064

avidov wants to merge 1 commit into from

Conversation

@avidov
Copy link
Contributor

@avidov avidov commented Dec 14, 2020 •
edited by 9prady9
Loading

Description

Followup on #3058
Tested with 3.7.1 with OpenCL backend

Changes to Users

None

Checklist

  • Rebased on latest master
  • Code compiles
  • Tests pass
  • [ ] Functions added to unified API
  • [ ] Functions documented

@avidov avidov mentioned this pull request Dec 14, 2020
Closed
@9prady9 9prady9 self-assigned this Feb 18, 2021
9prady9
9prady9 requested changes Feb 23, 2021
View reviewed changes
Copy link
Member

@9prady9 9prady9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are sorry about the delay.

Kindly address the feedback and rebase from latest master.

Note: We have done some significant amount of internal changes in terms of cmake. You don't need to do git submodule commands any more in ArrayFire. All dependencies that were earlier submodules are now fetched using cmake in the configure step.

@9prady9 9prady9 added the fix label Feb 23, 2021
@9prady9
Copy link
Member

9prady9 commented Feb 23, 2021

@avidov Kindly let us know if you cannot to look into it soon in which case I can take care of the changes.

Thank you for the contribution.

@9prady9
Copy link
Member

9prady9 commented Apr 9, 2021

@avidov I have taken care of the changes but I am unable to push them to this branch. Usually maintainers can to PR branches from different forks. Not sure what changed. I think Allow Edits from Maintainers was unchecked. Can you please change that. Or You can also address the feedback and let me know once you are done. Thank you

@9prady9
Copy link
Member

9prady9 commented Apr 9, 2021

@avidov Also, if you are addressing the feedback yourselves, please make sure the commit author detials are correct. Right now, it has "Your Name example@example.com" or something like that in commit message.

@9prady9
Copy link
Member

9prady9 commented May 5, 2021

Taking care of this change in #3130

@9prady9 9prady9 closed this May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@9prady9 9prady9 9prady9 requested changes

Assignees

@9prady9 9prady9

Labels

fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@avidov @9prady9