Move initializer_list constructor implementation to the header #2987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves the initialization list constructor to the header so that we avoid version conflicts between compilers for the implemenation of the initializer list. This approach will generate the initializer list constructor for the user's compiler and avoid such conflicts.
9prady9
approved these changes
Aug 12, 2020
| : arr(nullptr) { | ||
| const dim_t *size = dims.get(); | ||
| if (af_err __aferr = af_create_array( | ||
| &arr, list.begin(), AF_MAX_DIMS, size, |
Member
There was a problem hiding this comment.
nit: Would be better if dims.ndims() - doesn't depend on Dim4 having space allocated for AF_MAX_DIMS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the initialization list constructor to the header so that
we avoid version conflicts between compilers for the implemenation
of the initializer list. This approach will generate the initializer
list constructor for the user's compiler and avoid such conflicts.
Changes to Users
N/A
Checklist
[ ] Functions added to unified API