Propagate nvrtc errors up the stack in AFError exceptions #2948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* NVRTC errors were only printed in debug builds. The error messages were not passed to the exceptions thrown by the lib. This made it harder to debug issues
9prady9
approved these changes
Jun 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass error messages from NVRTC failures to AF_ERROR instead of suppressing the output.
Description
NVRTC errors were only printed in debug builds. The error messages
were not passed to the exceptions thrown by the lib. This made
it harder to debug issues.
Changes to Users
N/A
Checklist
[ ] Functions added to unified API[ ] Functions documented