Add move constructor and operator= for dim4, Array<T> SparseArray<T> #2946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9prady9
reviewed
Jun 26, 2020
Member
9prady9
left a comment
9prady9
left a comment
There was a problem hiding this comment.
No throw move constructors for CPU backend Array are not added. Any specific reason ?
Member
Author
|
That static check and constructor was added in the osx_fixes PR. I couldn't add it to these classes because of dim4's move assignment operator and constructor. |
Member
|
Got it. I didn't pull latest master after that PR merge, hence when I checked the file locally didn't find them in CPU backend. |
9prady9
approved these changes
Jul 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add nothrow move constructors for dim4. Array, SparseArray
Description
Create move constructors and move assignment operators for Array, SparseArray,
dim4. This adds move constructors for dim4 so this cannot be back ported.
Checklist