Fix ccache launch scripts to use sh compatible syntax #2931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlier to this change, I added bash based syntax which won't work with /bin/sh or dash shells. /usr/sh is available on most systems that use init.d scripts. So, it is safe to assume it's availability on majority of linux distributions.
Member
Author
|
The change works fine on Arch(sh -> bash) and Ubuntu(sh -> dash) too. This should be good for merge. @umar456 |
umar456
approved these changes
Jun 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier to this change, I added bash based syntax which won't work
with /bin/sh or dash shells.
/usr/sh is available on most systems that use init.d scripts. So, it is
safe to assume it's availability on majority of linux distributions.