Skip to content

Conversation

@9prady9
Copy link
Member

@9prady9 9prady9 commented May 19, 2020

Wow, this has been some tedious and tiring change!

But, it did the following:

  • Reduced OpenCL backend binary size by 6 MB i.e. 12% for RelWithDebInfo configuration, mostly due to reduction in instantiations
  • Brought down about ~ 2400 lines of repetitive code for from earlier style of caching.

@9prady9 9prady9 added this to the 3.7.2 milestone May 19, 2020
@9prady9 9prady9 requested a review from umar456 May 19, 2020 15:33
Copy link
Member

@umar456 umar456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing. I am really happy we finally removed the old way of finding kernels. This is a huge improvement in usability.

@9prady9 9prady9 merged commit 8f9f410 into arrayfire:master May 19, 2020
@9prady9 9prady9 deleted the refactor_ocl_caching branch May 19, 2020 18:03
umar456 pushed a commit to umar456/arrayfire that referenced this pull request Jun 27, 2020
* Refactor kernel wrappers to use new caching API

* Fix formatting
@umar456 umar456 mentioned this pull request Jun 27, 2020
2 tasks
9prady9 added a commit that referenced this pull request Jun 27, 2020
* Refactor kernel wrappers to use new caching API

* Fix formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants