Fix premature deallocation when deallocating with multiple devices. #2867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
umar456
commented
May 1, 2020
umar456
commented
- Fix an issue with multiple GPU and memory being freed because the correct device was not active when free was called.
- Update CLBlast to 1.5.1
- Set the minimum version for Boost
- Make sure that the downloaded version of Boost compute is preferred over the system version in case the Boost version is less than 1.7.1
- Remove old doxygen variable
- Fix const correctness of the operator* variable
* Arrays were being freed prematurely because the device associated with the array was not active. This change makes sure that we call setDevice before the memory is freed so we find the correct pointer in the memory manager.
syurkevi
previously approved these changes
May 1, 2020
9prady9
approved these changes
May 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.