Skip to content

Refactor padArray to reshape; Refactor qr,solve to use padArrayBorders #2864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
9prady9 merged 4 commits into from
Apr 29, 2020
Merged

Refactor padArray to reshape; Refactor qr,solve to use padArrayBorders #2864

9prady9 merged 4 commits into from
Apr 29, 2020
+494 −380

Conversation

@9prady9
Copy link
Member

@9prady9 9prady9 commented Apr 29, 2020

This includes a couple of other fixes too.

  • Fix mtx tests macro check in sparse_arith test
  • Handle zero padding case in padArrayBorders

@9prady9 9prady9 added this to the 3.7.2 milestone Apr 29, 2020
@9prady9 9prady9 requested a review from umar456 April 29, 2020 13:27
@9prady9 9prady9 marked this pull request as ready for review April 29, 2020 13:40
@9prady9 9prady9 changed the title Refactor padArray to resizeArray; Refactor qr,solve to use padArrayBorders Refactor padArray to reshape; Refactor qr,solve to use padArrayBorders Apr 29, 2020
umar456
umar456 reviewed Apr 29, 2020
View reviewed changes
@9prady9 9prady9 requested a review from umar456 April 29, 2020 14:54
@9prady9 9prady9 merged commit fbdf2d3 into arrayfire:master Apr 29, 2020
@9prady9 9prady9 deleted the resizeArray branch April 29, 2020 18:06
@umar456 umar456 mentioned this pull request Jun 27, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@umar456 umar456 umar456 approved these changes

Assignees

No one assigned

Labels

fix improvement

Projects

None yet

Milestone

3.7.2

Development

Successfully merging this pull request may close these issues.

2 participants

@9prady9 @umar456