Fix documentation to mem step size and clean up memory manager test #2821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jacobkahn
commented
Apr 2, 2020
jacobkahn
commented
- Add documentation to set and get mem step size functions in the C/C++ API to properly reflect behavior if a custom memory manager is set
- Remove af_event use from unlock in memory management test
- Ensure memory manager test memory pressure functions and gc threshold more closely matches default memory manager behavior
9prady9
previously requested changes
Apr 3, 2020
Member
9prady9
left a comment
9prady9
left a comment
There was a problem hiding this comment.
Can you please fix the formatting, else looks good.
|
|
||
| /// \brief Set the resolution of memory chunks | ||
| /// \brief Set the resolution of memory chunks. Works only with the default | ||
| /// memory manager - throws if a custom memory manager is set. |
| af_memory_manager_get_memory_pressure_threshold(manager, &threshold); | ||
| if (pressure > threshold) { signal_memory_cleanup_fn(manager); } | ||
| if (pressure >= threshold) { signal_memory_cleanup_fn(manager); } | ||
|
|
Member
There was a problem hiding this comment.
The changes in this file basically reflect the change in #2801 Is that correct ?
umar456
approved these changes
Apr 9, 2020
umar456
dismissed
9prady9’s stale review
I will fix the formatting in a future commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.