fix zero padding in convolve2NN #2820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9prady9
requested changes
Apr 3, 2020
Member
9prady9
left a comment
9prady9
left a comment
There was a problem hiding this comment.
Looks good. Can you please fix the formatting.
9prady9
approved these changes
Apr 7, 2020
Closed
umar456
pushed a commit
to umar456/arrayfire
that referenced
this pull request
Jul 3, 2020
* add tests for zero padding * fix clang formatting
9prady9
pushed a commit
that referenced
this pull request
Jul 5, 2020
* add tests for zero padding * fix clang formatting
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zero padding issue due to "empty" dim4 in c++ api.
adds fixes and simple tests addressing #2817