Make the symbolManager a static pointer to avoid destruction on exit #2769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umar456
force-pushed
the
unified_static
branch
from
e76993f to
daaca54
Compare
umar456
force-pushed
the
unified_static
branch
2 times, most recently
from
4cd6714 to
a09959c
Compare
* Avoid releasing symbol manager. Let OS release resources * Does not affect leak sanitizer * Use static instead of thread local to avoid loading the library multiple times * Move activeBackend and activeHandle out of symbol manager since AFSymbolManager is a singleton class now. It didn't make sense to have those variables in there anyway because they do not do anything with the symbols. Added multi-threaded tests to make sure expected behavior when switching backends
umar456
force-pushed
the
unified_static
branch
from
a09959c to
0e6dde3
Compare
9prady9
reviewed
Feb 18, 2020
9prady9
approved these changes
Feb 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
multiple times