Refactor image proc fns to use nvrtc API #2560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umar456
previously requested changes
Jul 2, 2019
Member
umar456
left a comment
umar456
left a comment
There was a problem hiding this comment.
Looks good. Made a couple of comments about the name of the kernel variables.
Member
Author
|
The problem is there, hence the addition.
…On Wed 3 Jul, 2019, 16:14 Umar Arshad, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/backend/cuda/nvrtc/cache.cpp
<#2560 (comment)>:
> @@ -120,6 +145,8 @@ Kernel buildKernel(const int device, const string &nameExpr,
} else {
constexpr static const char *includeNames[] = {
"math.h", // DUMMY ENTRY TO SATISFY cuComplex_h inclusion
+ "stdbool.h", // DUMMY ENTRY TO SATISFY af/defines.h inclusion
Its a compiler guard similar to checking for gcc or clang. It is not
defined by ArrayFire.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2560?email_source=notifications&email_token=AAY6OOR2WCWYMLOOZ6IW5VTP5R7HJA5CNFSM4H4K3AA2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB5L26WI#discussion_r299891903>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAY6OOVCOHZ2KUQW4MU5NDTP5R7HJANCNFSM4H4K3AAQ>
.
|
umar456
approved these changes
Jul 5, 2019
This was referenced Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.