Skip to content

Conversation

@shehzan10
Copy link
Member

[skip ci]

Fixes #1378

@shehzan10 shehzan10 added the CPU label Apr 7, 2016
@shehzan10 shehzan10 added this to the 3.3.2 milestone Apr 7, 2016
@shehzan10
Copy link
Member Author

In the current code, if the compiler is older than 4.8.4, then there is no way to compile it for Async also (cant force it either since the option itself is entirely removed). This would cause a lot of problems.
There are 2 options to fix it:

  1. Instead of deleting the variable itself, we can set it to OFF when the compiler is older.
  2. Have a separate variable, say FORCE_CPU_ASYNC_COMPILE that would bypass the compiler version check.

I think the first option is more clean.

User can still set it on in CMake
@shehzan10
Copy link
Member Author

Fixed the last comment. CMake will turn off the async variable if an older compiler is detected, but user can set it to on.

@pavanky pavanky merged commit ab2f36c into arrayfire:hotfix-3.3.2 Apr 12, 2016
@shehzan10 shehzan10 deleted the cpu-async-gcc branch April 12, 2016 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants