Skip to content

Bug Fixes for 3.3.1 #1314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shehzan10 merged 2 commits into from
Mar 4, 2016
Merged

Bug Fixes for 3.3.1 #1314

shehzan10 merged 2 commits into from
Mar 4, 2016

Conversation

@pavanky
Copy link
Member

@pavanky pavanky commented Mar 3, 2016

  • Fixed getting device pointer out of OpenCL backend
  • Fixed unified backend to load SO versioned libraries

@pavanky pavanky added this to the 3.3.1 milestone Mar 3, 2016
@pavanky pavanky added the bug label Mar 3, 2016
9prady9
9prady9 reviewed Mar 3, 2016
View reviewed changes
src/api/unified/symbol_manager.cpp Outdated
static const string LIB_AF_BKND_SUFFIX = ".3.dylib";
#else
static const string LIB_AF_BKND_SUFFIX = ".so";
static const string LIB_AF_BKND_SUFFIX = ".so.3";
Copy link
Member

@9prady9 9prady9 Mar 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pavanky May be we can append the version number programmatically instead of hard coding it ?

Copy link
Member Author

@pavanky pavanky Mar 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@9prady9 That makes sense. Let me resend the PR.

@pavanky
Copy link
Member Author

pavanky commented Mar 3, 2016

@9prady9 updated.

@9prady9
Copy link
Member

9prady9 commented Mar 3, 2016

do you want to build it or shall i go ahead and merge it ?

@pavanky
Copy link
Member Author

pavanky commented Mar 3, 2016

@9prady9 build on linux and osx before merge.

@pavanky
Copy link
Member Author

pavanky commented Mar 3, 2016

build arrayfire linux ci

@pavanky
Copy link
Member Author

pavanky commented Mar 3, 2016

build arrayfire osx ci

@pavanky
Copy link
Member Author

pavanky commented Mar 4, 2016

build arrayfire linux ci

build arrayfire osx ci

@shehzan10
Copy link
Member

shehzan10 commented Mar 4, 2016

build arrayfire osx ci

shehzan10 added a commit that referenced this pull request Mar 4, 2016
@shehzan10
Merge pull request #1314 from pavanky/fixes-3.3.1
63af426 
Bug Fixes for 3.3.1
@shehzan10 shehzan10 merged commit 63af426 into arrayfire:hotfix-3.3.1 Mar 4, 2016
@pavanky pavanky deleted the fixes-3.3.1 branch March 4, 2016 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

3.3.1

Development

Successfully merging this pull request may close these issues.

3 participants

@pavanky @9prady9 @shehzan10