Examples clean up and test fixes #1158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
examples/graphics/surface.cpp
Outdated
Member
There was a problem hiding this comment.
POINTS is a typedef to a struct on Windows in windef.h. That's causing build failure.
Member
|
Lets put |
- Replaced getchar within ifdefs with a new macro - Cleaned up unneeded "console" options from a few examples - Removed getchar option for windows. - This was already available via cmake
pavanky
force-pushed
the
example_fixes
branch
from
8a96c0c to
52a8409
Compare
Member
|
For the record, we will be adding The purpose of the getchar was to prevent the command prompts from exiting without user input when run without the VS debugger (Ctrl + F5). This can be achieved by using |
shehzan10
added a commit
that referenced
this pull request
Dec 14, 2015
Examples clean up and test fixes
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[skip ci]
getchar()for windows