Memory leak fix in SUSAN feature detector #1096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This is ready for merge. Pending checks from new Linux nodes can be ignored, those builds were cancelled. |
Member
Author
|
I will send in another fix in this PR, don't merge this yet please. |
abs(int) and abs(char) were always returning zeros on CUDA backend, probably a bug in CUDA sdk. This change fixes this behaviour on CUDA backend which effects the following functions: * af_assign_gen * af_index_gen
Member
Author
|
Additional fixes are in. Ready for merge once tests pass. |
Member
|
@9prady9 can you add a test for the failure case so that we know if it ever happens again? |
Member
Author
|
Added it. |
Member
Author
|
build arrayfire ci |
1 similar comment
Member
|
build arrayfire ci |
Member
|
build arrayfire windows ci |
Member
|
The windows build passed a manual build http://ci.arrayfire.org/job/arrayfire-windows-pull/300/. |
shehzan10
added a commit
that referenced
this pull request
Nov 11, 2015
Memory leak fix in SUSAN feature detector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1092 - CUDA backend Indexing bug.