Fix typos, duplicated params, keywords casing#2
Open
LiborKuchejda wants to merge 1 commit intoarray-analytics:masterfrom
Open
Fix typos, duplicated params, keywords casing#2LiborKuchejda wants to merge 1 commit intoarray-analytics:masterfrom
LiborKuchejda wants to merge 1 commit intoarray-analytics:masterfrom
Conversation
|
Looking to bump this pull request, as this repo's code in master doesn't run without these changes from the fork. |
rhux
suggested changes
Apr 14, 2020
Contributor
rhux
left a comment
rhux
left a comment
There was a problem hiding this comment.
Can you please remove the function deletion from file 8. Then I'll approve the rest of the changes.
Thank you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was not able to run scripts right away. There were small typos and function overloads with params that were similar to other function definitions because of default values.
Fixing those, tested on azure database for postgre v10
Thanks for your effort.