action: leave torrent URLs empty in per-image asset manifests#9792
Merged
Conversation
The build action ships images, .asc and .sha files alongside its artefacts but never produces a .torrent. Until now the manifest's file_url_torrent and redi_url_torrent fields still got constructed by appending '.torrent' to the file URL, so consumers of the manifest saw URLs that always 404. Return an empty string from signature_urls() for the torrent slot so both file_url_torrent and redi_url_torrent are empty in the per-image `<image>.assets.json`. The fields stay present for schema parity with the canonical armbian-images.json index — if torrents ever start being produced upstream, only the helper needs to change.
Contributor
📝 WalkthroughWalkthroughThe release assets manifest generation in ChangesRelease Assets Manifest URL Handling
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The composite action publishes images plus their
.ascand.shasiblings, but it never produces a.torrentfor any artefact it ships. Despite that, the per-image<image>.assets.jsonmanifest emitted by the manifest step always wrote constructed URLs intofile_url_torrentandredi_url_torrentby appending.torrentto the file URL — so consumers of the manifest were greeted with URLs that 404.This PR makes those two fields empty strings in manifests produced by this action, while keeping the field names present so the schema still matches the canonical
armbian-images.jsonindex thatarmbian.github.iopublishes.Ref: armbian/website#21
Change
action.yml→signature_urls()returns(base, base.asc, base.sha, "")instead of(base, base.asc, base.sha, base.torrent). Bothfile_url_torrentandredi_url_torrentflow from this single helper, so they both become"". Docstrings updated to spell out the convention.If/when torrents ever start being produced by the action, only this helper needs to change.
Test plan
armbian/build@mainpin.<image>.assets.jsonfrom the resulting release:file_url_torrentandredi_url_torrentare""(still present).file_url_asc,file_url_sha,redi_url_asc,redi_url_shaare unchanged in shape.Summary by CodeRabbit