Skip to content

rockchip64-7.0: mekotronics-r58x-pro: analog sound: use SuperKali's new clock#9554

Merged
igorpecovnik merged 2 commits into
armbian:mainfrom
rpardini:pr/rockchip64-70-mekotronics-r58x-pro-analog-sound-use-SuperKalis-new-clock
Mar 19, 2026
Merged

rockchip64-7.0: mekotronics-r58x-pro: analog sound: use SuperKali's new clock#9554
igorpecovnik merged 2 commits into
armbian:mainfrom
rpardini:pr/rockchip64-70-mekotronics-r58x-pro-analog-sound-use-SuperKalis-new-clock

Conversation

@rpardini
Copy link
Copy Markdown
Member

@rpardini rpardini commented Mar 18, 2026 •
edited by coderabbitai Bot
Loading

rockchip64-7.0: mekotronics-r58x-pro: analog sound: use SuperKali's new clock

  • 🌱 rockchip64-7.0: mekotronics-r58x-pro: convert analog audio to simple-audio-card
  • 🌴 rockchip64-7.0: mekotronics-r58x-pro: analog sound: use SuperKali's new clock

    This series fixes ES8388 audio on the Mekotronics R58X-Pro (RK3588). >
    Without these patches, the i2s0_8ch_mclkout_to_io gate remains closed
    (enable_count=0 in the clk_summary), and the codec receives no master
    clock. DAPM reports all widgets as powered on and playback streams run
    without errors, but the hardware produces no sound — a rather
    frustrating failure mode to debug. >
    With the series applied and the board DTS updated to reference
    I2S0_8CH_MCLKOUT_TO_IO from the codec node: >
    es8388: audio-codec@10 {
    compatible = "everest,es8388", "everest,es8328";
    reg = <0x10>;
    clocks = <&cru I2S0_8CH_MCLKOUT_TO_IO>;
    assigned-clocks = <&cru I2S0_8CH_MCLKOUT>;
    assigned-clock-rates = <12288000>;
    ...
    }; >
    audio playback works correctly, tested via headphones output. >
    Tested-by: Ricardo Pardini ricardo@pardini.net

Summary by CodeRabbit

  • Chores
    • Updated audio hardware configuration for improved compatibility and stability on the Mekotronics R58x Pro board.

rpardini added 2 commits March 17, 2026 21:22
@rpardini
rockchip64-7.0: mekotronics-r58x-pro: convert analog audio to simple-…
24fdc36 
…audio-card

- `audio-graph-card` actually never worked, I messed up
- Daniele has the real fix up in https://lore.kernel.org/linux-rockchip/20260316-rk3588-mclk-gate-grf-v1-0-66fb9a246718@superkali.me/
- convert to `simple-audio-card` before actually adding it, so playing field is even
@rpardini
rockchip64-7.0: mekotronics-r58x-pro: analog sound: use SuperKali's n…
114b73f 
…ew clock

> This series fixes ES8388 audio on the Mekotronics R58X-Pro (RK3588).
>
> Without these patches, the i2s0_8ch_mclkout_to_io gate remains closed
> (enable_count=0 in the clk_summary), and the codec receives no master
> clock. DAPM reports all widgets as powered on and playback streams run
> without errors, but the hardware produces no sound — a rather
> frustrating failure mode to debug.
>
> With the series applied and the board DTS updated to reference
> I2S0_8CH_MCLKOUT_TO_IO from the codec node:
>
>     es8388: audio-codec@10 {
>         compatible = "everest,es8388", "everest,es8328";
>         reg = <0x10>;
>         clocks = <&cru I2S0_8CH_MCLKOUT_TO_IO>;
>         assigned-clocks = <&cru I2S0_8CH_MCLKOUT>;
>         assigned-clock-rates = <12288000>;
>         ...
>     };
>
> audio playback works correctly, tested via headphones output.
>
> Tested-by: Ricardo Pardini <ricardo@pardini.net>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 18, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 49dabcef-59a9-4afe-a436-3886b63a9791

📥 Commits

Reviewing files that changed from the base of the PR and between ed1e2f2 and 114b73f.

📒 Files selected for processing (1)
  • patch/kernel/archive/rockchip64-7.0/dt/rk3588-mekotronics-r58x-pro.dts
📝 Walkthrough

Walkthrough

The audio configuration in a Rockchip device tree file is updated from a legacy audio-graph-card setup to a modern simple-audio-card configuration. Clock references, supply rails, and structural organization are adjusted to align with the new audio card model.

Changes

Cohort / File(s) Summary
Audio Configuration Update
patch/kernel/archive/rockchip64-7.0/dt/rk3588-mekotronics-r58x-pro.dts		 Replaces legacy audio-graph-card with simple-audio-card for ES8388 codec. Updates clocking from dedicated mclk path to I2S0_8CH_MCLKOUT_TO_IO. Adds codec supply rails (AVDD, DVDD, HPVDD, PVDD). Removes endpoint-based configuration and restructures device tree nodes with new daicpu and codec subnodes. Updates pinctrl groups to include i2s0_mclk. Renames sound node to analog-sound with updated card identity.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 Hops with glee through audio trees,
Old graph cards replaced with ease,
ES8388 now shines so bright,
With simple cards and clocks set right,
Supply rails wired, configs clean,
The finest sound device tree seen! 🎵

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'rockchip64-7.0: mekotronics-r58x-pro: analog sound: use SuperKali's new clock' accurately reflects the main change: updating the Mekotronics R58X-Pro device tree to use new clock configuration for ES8388 audio support.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added 05 Milestone: Second quarter release size/medium PR with more then 50 and less then 250 lines Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... labels Mar 18, 2026
@rpardini rpardini marked this pull request as ready for review March 18, 2026 00:22
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 18, 2026

✅ This PR has been reviewed and approved — all set for merge!

@github-actions github-actions Bot added Ready to merge Reviewed, tested and ready for merge and removed Needs review Seeking for review labels Mar 18, 2026
@rpardini
Copy link
Copy Markdown
Member Author

rpardini commented Mar 18, 2026

  • Hold on to this for a bit, as the new I2S0_8CH_MCLKOUT_TO_IO constant is ofc not available in u-boot and uboot build breaks (DT is symlinked.... has been proven a bad idea before too)
  • There is no 6.18/current for Meko's, so nothing to backport here

@igorpecovnik igorpecovnik merged commit 2ea7ed8 into armbian:main Mar 19, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperKali SuperKali SuperKali approved these changes

@ColorfulRhino ColorfulRhino Awaiting requested review from ColorfulRhino ColorfulRhino is a code owner

@HeyMeco HeyMeco Awaiting requested review from HeyMeco HeyMeco is a code owner

@JohnTheCoolingFan JohnTheCoolingFan Awaiting requested review from JohnTheCoolingFan JohnTheCoolingFan is a code owner

@TheSnowfield TheSnowfield Awaiting requested review from TheSnowfield TheSnowfield is a code owner

@Tonymac32 Tonymac32 Awaiting requested review from Tonymac32 Tonymac32 is a code owner

@ahoneybun ahoneybun Awaiting requested review from ahoneybun ahoneybun is a code owner

@amazingfate amazingfate Awaiting requested review from amazingfate amazingfate is a code owner

@brentr brentr Awaiting requested review from brentr brentr is a code owner

@catalinii catalinii Awaiting requested review from catalinii catalinii is a code owner

@chainsx chainsx Awaiting requested review from chainsx chainsx is a code owner

@efectn efectn Awaiting requested review from efectn efectn is a code owner

@igorpecovnik igorpecovnik Awaiting requested review from igorpecovnik igorpecovnik is a code owner

@joekhoobyar joekhoobyar Awaiting requested review from joekhoobyar joekhoobyar is a code owner

@krachlatte krachlatte Awaiting requested review from krachlatte krachlatte is a code owner

@lanefu lanefu Awaiting requested review from lanefu lanefu is a code owner

@paolosabatino paolosabatino Awaiting requested review from paolosabatino paolosabatino is a code owner

@prahal prahal Awaiting requested review from prahal prahal is a code owner

@pyavitz pyavitz Awaiting requested review from pyavitz pyavitz is a code owner

@schwar3kat schwar3kat Awaiting requested review from schwar3kat schwar3kat is a code owner

Assignees

No one assigned

Labels

05 Milestone: Second quarter release Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/medium PR with more then 50 and less then 250 lines

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rpardini @SuperKali @igorpecovnik