fix: resolve Phytium stmmac compilation errors for kernel 6.19#9545
Merged
Conversation
Add new patch (1004) to fix compilation warnings and errors in the Phytium ethernet driver patches for kernel 6.19: - Make fw_get_phy_mode() static to resolve missing prototype warning - Make stmmac_acpi_clock_setup() static to resolve missing prototype warning - Remove invalid stmmac_res->lpi_irq assignment (member doesn't exist) This patch should be applied after patches 1000-1003 to complete the Phytium ethernet driver support for kernel 6.19.
Update patch 1004 to also fix compilation issues in dwmac-phytium.c: - Make dwmac_phytium_get_resources() static to resolve missing prototype warning - Remove invalid stmmac_res->lpi_irq = -ENOENT assignment (member doesn't exist) The patch now fixes all compilation issues across both files: - stmmac_platform.c: fw_get_phy_mode(), stmmac_acpi_clock_setup(), lpi_irq - dwmac-phytium.c: dwmac_phytium_get_resources(), lpi_irq All Phytium ethernet driver patches (1000-1004) should now compile cleanly.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughA patch file is being added to fix stmmac driver compilation warnings by making three functions static to resolve missing prototype warnings and removing invalid lpi_irq field assignments across two source files. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
05
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes compilation warnings and errors in Phytium ethernet driver patches for kernel 6.19 by adding patch 1004.
Changes
1004-fix-stmmac-compilation-warnings.patchthat resolves all compilation issuesFixes Applied
In
stmmac_platform.c:fw_get_phy_mode()static to resolve missing prototype warningstmmac_acpi_clock_setup()static to resolve missing prototype warningstmmac_res->lpi_irq = -1;assignment (member doesn't exist in kernel 6.19)In
dwmac-phytium.c:dwmac_phytium_get_resources()static to resolve missing prototype warningstmmac_res->lpi_irq = -ENOENT;assignment (member doesn't exist in kernel 6.19)Test Plan
Context
The Phytium ethernet driver patches (1000-1003) were partially applying but had compilation issues due to:
lpi_irqmember access instmmac_resourcesstruct (removed in kernel 6.19)Patch 1004 should be applied after patches 1000-1003 to complete the Phytium ethernet support for kernel 6.19.
Summary by CodeRabbit
Release Notes
Bug Fixes
Chores