Skip to content

maint: meson64-current: rewrite patches against 6.18.18#9528

Merged
EvilOlaf merged 1 commit into
armbian:mainfrom
EvilOlaf:meson64-maint
Mar 14, 2026
Merged

maint: meson64-current: rewrite patches against 6.18.18#9528
EvilOlaf merged 1 commit into
armbian:mainfrom
EvilOlaf:meson64-maint

Conversation

@EvilOlaf
Copy link
Copy Markdown
Member

@EvilOlaf EvilOlaf commented Mar 14, 2026 •
edited by coderabbitai Bot
Loading

as per title

Summary by CodeRabbit

  • New Features

    • Added SPI device support for additional device types

  • Bug Fixes

    • Improved error handling and cleanup in fan controller driver
    • Added support for additional fan controller device variants
    • Optimized MMC clock phase configuration for SD card slots

  • Refactor

    • Simplified PCI controller Maximum Payload Size configuration handling

@github-actions github-actions Bot added 05 Milestone: Second quarter release size/small PR with less then 50 lines labels Mar 14, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 14, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 2582f9f9-f660-4501-a34e-c40370268e10

📥 Commits

Reviewing files that changed from the base of the PR and between 58907a3 and eefbf16.

📒 Files selected for processing (4)
  • patch/kernel/archive/meson64-6.18/drv-spi-spidev-remove-warnings.patch
  • patch/kernel/archive/meson64-6.18/general-meson-mmc-2-arm64-amlogic-dts-meson-update-meson-axg-device-tree.patch
  • patch/kernel/archive/meson64-6.18/hwmon-emc2305-fixups-for-driver.patch
  • patch/kernel/archive/meson64-6.18/x-PATCH-v7-2-2-PCI-dwc-Remove-redundant-MPS-configuration.patch
📝 Walkthrough

Walkthrough

The PR applies multiple kernel patches to the Meson64 architecture, including device ID additions to the spidev driver, MMC device-tree updates for phase clock customization, substantial improvements to the EMC2305 fan controller driver with enhanced error handling and cleanup paths, and removes redundant PCI Maximum Payload Size configuration logic.

Changes

Cohort / File(s) Summary
SPI Device Support
patch/kernel/archive/meson64-6.18/drv-spi-spidev-remove-warnings.patch		 Adds new SPI device ID entries: inserts { .name = "spi-dev" } to spidev_spi_ids array and { .compatible = "armbian,spi-dev", .data = &spidev_of_check } to spidev_dt_ids array.
Device-Tree MMC Configuration
patch/kernel/archive/meson64-6.18/general-meson-mmc-2-arm64-amlogic-dts-meson-update-meson-axg-device-tree.patch		 Updates MMC device-tree nodes (sd_emmc_b, sd_emmc_c) with phase clock customization via amlogic,mmc-phase attribute; removes legacy assigned-clock-rates; adds meson-gx-mmc bindings include.
EMC2305 Fan Controller Driver
patch/kernel/archive/meson64-6.18/hwmon-emc2305-fixups-for-driver.patch		 Introduces pwm_max boundary handling and device-tree overrides; adds emc2305_unset_tz cleanup function with new thermal error path; implements remove callback for proper device cleanup; extends device matching with additional compatible strings; adds fault status acknowledgment at probe end.
PCI DWC MPS Configuration
patch/kernel/archive/meson64-6.18/x-PATCH-v7-2-2-PCI-dwc-Remove-redundant-MPS-configuration.patch		 Removes redundant meson_set_max_payload helper and its invocation; delegates MPS tuning to generic pci_configure_mps logic in the generic DWC framework.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 Hops of silicon, patches so fine,
Device trees bloom on the Meson line,
Fans spin cooler, controllers refined,
With cleanup and care, no bugs left behind! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'maint: meson64-current: rewrite patches against 6.18.18' accurately and specifically describes the primary change: rewriting Meson64 patches to target Linux kernel version 6.18.18.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... labels Mar 14, 2026
@github-actions github-actions Bot added the Ready to merge Reviewed, tested and ready for merge label Mar 14, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 14, 2026

✅ This PR has been reviewed and approved — all set for merge!

@github-actions github-actions Bot removed the Needs review Seeking for review label Mar 14, 2026
@EvilOlaf EvilOlaf merged commit d48b578 into armbian:main Mar 14, 2026
1 check passed
@EvilOlaf EvilOlaf deleted the meson64-maint branch March 14, 2026 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pyavitz pyavitz pyavitz approved these changes

@NicoD-SBC NicoD-SBC Awaiting requested review from NicoD-SBC NicoD-SBC is a code owner

@SteeManMI SteeManMI Awaiting requested review from SteeManMI SteeManMI is a code owner

@Tonymac32 Tonymac32 Awaiting requested review from Tonymac32 Tonymac32 is a code owner

@adeepn adeepn Awaiting requested review from adeepn adeepn is a code owner

@igorpecovnik igorpecovnik Awaiting requested review from igorpecovnik igorpecovnik is a code owner

@rpardini rpardini Awaiting requested review from rpardini rpardini is a code owner

@teknoid teknoid Awaiting requested review from teknoid teknoid is a code owner

Assignees

No one assigned

Labels

05 Milestone: Second quarter release Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@EvilOlaf @pyavitz