Skip to content

Reword BTF memory check#9502

Merged
EvilOlaf merged 1 commit into
armbian:mainfrom
x13-me:main
Mar 9, 2026
Merged

Reword BTF memory check#9502
EvilOlaf merged 1 commit into
armbian:mainfrom
x13-me:main

Conversation

@x13-me
Copy link
Copy Markdown
Contributor

@x13-me x13-me commented Mar 8, 2026 •
edited by coderabbitai Bot
Loading

Description

This commit rewords the BTF memory check in lib/functions/compilation/armbian-kernel.sh to include the value checked against

Additionally, the unit is correctly set as MiB

Resolves 9501 GitHub issue

Summary by CodeRabbit

  • Bug Fixes
    • Improved kernel compilation memory requirement checks to dynamically validate RAM against BTF build needs with clearer feedback on available versus required memory.

@x13-me
Reword BTF memory check
32f51a2 
This commit rewords the BTF memory check in lib/functions/compilation/armbian-kernel.sh to include the value checked against

Additionally, the unit is correctly set as MiB
@x13-me x13-me requested a review from a team as a code owner March 8, 2026 15:45
@x13-me x13-me requested review from mhoffrog and schwar3kat and removed request for a team March 8, 2026 15:45
@github-actions github-actions Bot added size/small PR with less then 50 lines 05 Milestone: Second quarter release Needs review Seeking for review Framework Framework components labels Mar 8, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 8, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 066f3150-97c9-4629-a76a-e6447d189975

📥 Commits

Reviewing files that changed from the base of the PR and between 335f01e and 32f51a2.

📒 Files selected for processing (1)
  • lib/functions/compilation/armbian-kernel.sh
📝 Walkthrough

Walkthrough

This change enhances memory requirement handling for BTF-related kernel build steps by introducing a configurable memory threshold variable (needed_physical_memory_mib set to 6451 MiB) and computing available physical memory. Hard-coded threshold comparisons are replaced with dynamic variable references, and user-facing messages are updated to display both available and required RAM values.

Changes

Cohort / File(s) Summary
BTF Memory Check Enhancement
lib/functions/compilation/armbian-kernel.sh		 Introduced needed_physical_memory_mib variable and available_physical_memory_mib computation to replace hard-coded memory threshold value. Updated user-facing messages and error texts to dynamically reference the threshold and display both available and required RAM in MiB.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A memory threshold takes shape,
With MiB values now escape,
From static chains to dynamic flow,
BTF builds get what they know! ✨
The kernel checks before it flies,
With clearer messages and honest eyes.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Reword BTF memory check' directly matches the main change: rewording the BTF memory check messages and correcting the memory unit to MiB in lib/functions/compilation/armbian-kernel.sh.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

iav
iav approved these changes Mar 8, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@iav iav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 8, 2026

✅ This PR has been reviewed and approved — all set for merge!

@github-actions github-actions Bot added Ready to merge Reviewed, tested and ready for merge and removed Needs review Seeking for review labels Mar 8, 2026
@EvilOlaf EvilOlaf merged commit d61dfc3 into armbian:main Mar 9, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iav iav iav approved these changes

@mhoffrog mhoffrog Awaiting requested review from mhoffrog mhoffrog is a code owner automatically assigned from armbian/build-scripts

@schwar3kat schwar3kat Awaiting requested review from schwar3kat schwar3kat is a code owner automatically assigned from armbian/build-scripts

Assignees

No one assigned

Labels

05 Milestone: Second quarter release Framework Framework components Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@x13-me @iav @EvilOlaf