patch/kernel/archive/spacemit-7.0/002-PATCH-v3-0-3-thermal-spacemit-Add-support-for-SpacemiT-K1-SoC-thermal-sensor.patch (3)

421-448: Clarify interrupt register semantics.

The interrupt enable/mask logic appears inconsistent at first glance:

• Line 422: Writing 0xffffffff to "disable all interrupts"
• Line 447: Setting K1_TSENSOR_INT_EN_MASK (bit 0) to "enable thermal interrupt"
• Line 467: Clearing bits in k1_tsensor_enable_irq() to enable per-sensor interrupts

This suggests bit 0 is a global enable (active-high) while bits 1+ are per-sensor masks (active-high = masked). The register naming INT_EN_REG is potentially misleading since it appears to function as both an enable and mask register. Consider adding a brief comment explaining this dual behavior for future maintainers.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In
`@patch/kernel/archive/spacemit-7.0/002-PATCH-v3-0-3-thermal-spacemit-Add-support-for-SpacemiT-K1-SoC-thermal-sensor.patch`
around lines 421 - 448, The interrupt register K1_TSENSOR_INT_EN_REG is used as
both a global enable (bit 0, K1_TSENSOR_INT_EN_MASK) and per-sensor mask bits
(bits 1+, manipulated in k1_tsensor_enable_irq()), which is confusing given the
name; add a short clarifying comment near the writes that first write 0xffffffff
and later set K1_TSENSOR_INT_EN_MASK (and reference k1_tsensor_enable_irq())
explaining that bit 0 is a global active-high interrupt enable while the upper
bits are per-sensor active-high masks, so code readers understand the dual
semantics.

---

528-531: Minor cleanup: remove unnecessary cast and use u32 for register values.

• Line 530: The C-style cast (struct k1_tsensor *) is unnecessary as void * converts implicitly.
• Line 531: mask and status hold register values and should be u32 for consistency with other register operations in the driver.

♻️ Suggested cleanup

 static irqreturn_t k1_tsensor_irq_thread(int irq, void *data)
 {
-	struct k1_tsensor *ts = (struct k1_tsensor *)data;
-	int mask, status, i;
+	struct k1_tsensor *ts = data;
+	u32 mask, status;
+	int i;

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In
`@patch/kernel/archive/spacemit-7.0/002-PATCH-v3-0-3-thermal-spacemit-Add-support-for-SpacemiT-K1-SoC-thermal-sensor.patch`
around lines 528 - 531, In k1_tsensor_irq_thread, remove the unnecessary C-style
cast on the data argument by assigning data directly to ts (i.e., use "struct
k1_tsensor *ts = data;") and change the types of register-related variables mask
and status from int to u32 to match other register operations in the driver
(keep loop/index variable i as int); update the variable declarations in the
function signature/body accordingly.

---

581-600: Consider adding error context on probe failures.

The thermal zone registration (line 582) and IRQ request (line 599-600) failures return error codes without descriptive messages, which could make debugging harder during board bring-up. Using dev_err_probe() would provide consistent error reporting.

♻️ Suggested improvement

 		ts->ch[i].tzd = devm_thermal_of_zone_register(dev, i, ts->ch + i, &k1_tsensor_ops);
 		if (IS_ERR(ts->ch[i].tzd))
-			return PTR_ERR(ts->ch[i].tzd);
+			return dev_err_probe(dev, PTR_ERR(ts->ch[i].tzd),
+					     "Failed to register thermal zone %d\n", i);
 ...
 	ret = devm_request_threaded_irq(dev, irq, NULL,
 					k1_tsensor_irq_thread,
 					IRQF_ONESHOT, "k1_tsensor", ts);
 	if (ret < 0)
-		return ret;
+		return dev_err_probe(dev, ret, "Failed to request IRQ\n");

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In
`@patch/kernel/archive/spacemit-7.0/002-PATCH-v3-0-3-thermal-spacemit-Add-support-for-SpacemiT-K1-SoC-thermal-sensor.patch`
around lines 581 - 600, Replace raw error returns on thermal zone registration
and IRQ request with dev_err_probe-style reporting: when IS_ERR(ts->ch[i].tzd)
is true and when devm_thermal_add_hwmon_sysfs() or devm_request_threaded_irq()
fail, call dev_err_probe(dev, err, "...") (or use dev_err_probe with the
returned negative code) to log a descriptive message (e.g., "failed to register
thermal zone %d" or "failed to request IRQ %d") before returning the error;
update the probe path around the checks for ts->ch[i].tzd,
devm_thermal_add_hwmon_sysfs(dev, ts->ch[i].tzd) and
devm_request_threaded_irq(..., k1_tsensor_irq_thread, ...) to use dev_err_probe
for consistent error context and then return the error code.

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Jira integration is disabled

You can enable these sources in your CodeRabbit configuration.