Add radxa-dragon-q6a to nightly release blacklist#260
Conversation
github-actions
Bot
added
05
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughTwo target identifiers, Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
release-targets/targets-release-nightly.blacklist (1)
1-25: Consider alphabetically sorting the blacklist for easier maintenance.While the new entry is correct, the file would benefit from consistent alphabetical ordering. Currently, entries like
oneplus-kebab,xiaomi-elish,uefi-x86, and themekotronicsboards are out of alphabetical sequence. If alphabetically sorted,radxa-dragon-q6awould appear betweenradxa-zero(line 16) andrenegade(line 17).This is purely a maintainability consideration and doesn't affect functionality.
📋 Proposed alphabetically sorted version
bananapim2pro bananapi-m2s jethub-d1 jethub-h1 jethubj80 jethubj100 jethubj200 khadas-vim1 khadas-vim2 lafrite lepotato +mekotronics-r58-4x4 +mekotronics-r58hd odroidc2 olimex-teres-a64 onecloud +oneplus-kebab pine64 +radxa-dragon-q6a radxa-zero renegade tritium-h3 tritium-h5 -oneplus-kebab -xiaomi-elish uefi-x86 -mekotronics-r58-4x4 -mekotronics-r58hd -radxa-dragon-q6a +xiaomi-elish🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@release-targets/targets-release-nightly.blacklist` around lines 1 - 25, The blacklist entries should be alphabetized for maintainability: reorder the lines so entries are in ascending alphabetical order (e.g., place radxa-dragon-q6a between radxa-zero and renegade) and move mekotronics-r58-4x4 / mekotronics-r58hd, oneplus-kebab, uefi-x86, and xiaomi-elish into their correct alphabetic positions; update the file so every line is sorted lexicographically while preserving the same entries.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@release-targets/targets-release-nightly.blacklist`:
- Around line 1-25: The blacklist entries should be alphabetized for
maintainability: reorder the lines so entries are in ascending alphabetical
order (e.g., place radxa-dragon-q6a between radxa-zero and renegade) and move
mekotronics-r58-4x4 / mekotronics-r58hd, oneplus-kebab, uefi-x86, and
xiaomi-elish into their correct alphabetic positions; update the file so every
line is sorted lexicographically while preserving the same entries.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 9d9cfbb5-bee5-4a16-8fc0-8b69a6afbb57
📒 Files selected for processing (1)
release-targets/targets-release-nightly.blacklist
Broken https://paste.armbian.com/higekusile @FantasyGmm revert once fixed
1 participant
Summary
radxa-dragon-q6ato the nightly release blacklist@HeyMeco revert once aic driver is in shape.
Test plan