Fix scoping in the Composite context #3799
Conversation
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
@diegohaz any quick way to create a starter codesandbox using this PR's version? |
I'm not sure. It used to be generated automatically, but it stopped working suddenly a while ago. |
There was a problem hiding this comment.
Thanks @DaniGuardiola!
The changes make sense and align with how other composite components are implemented. It would be nice to have a simple example of what you're trying to do on WordPress that triggered this issue.
|
Thanks @diegohaz, here's the example: https://stackblitz.com/edit/vitejs-vite-ihjzqp?file=src%2FApp.tsx This should work with this PR's version. |
Thanks! Would you mind turning that into an example with tests (without a readme.md file) for this PR? |
|
@diegohaz of course, I actually already have that locally since I needed to test it, I just didn't push it haha. Didn't realize you were referring to that. I will push it in a bit. |
…iakit/ariakit into fix/composite-context-scoping
|
@diegohaz pushed, let me know if the test is adequate. Here's a demo of it: Kapture.2024-05-20.at.23.08.36.mp4 |
This PR changes the output of the `render` function of `@ariakit/test`
to return `rerender`. Previously, it returned the `unmount` function
directly, and now it returns an object with the shape `{ unmount,
rerender }`.
Context:
#3939 (comment)
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Fixes #3768