Change file name pattern for snap files - #852
Merged
Merged
Conversation
cburgdorf
commented
Feb 28, 2023
| @@ -1,5 +1,6 @@ | |||
| --- | |||
| source: crates/tests/src/features.rs | |||
| assertion_line: 1779 | |||
Collaborator
Author
There was a problem hiding this comment.
Not exactly sure why assertion_line wasn't part of the file before but it came up as I regenerated the files.
Y-Nak
approved these changes
Feb 28, 2023
Y-Nak
left a comment
Y-Nak
left a comment
Member
There was a problem hiding this comment.
LGTM!
BTW, I think it's about time to consider another way to record gas usage. Using insta for this purpose is not so good. @g-r-a-n-t
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong?
The snap file name pattern was recently tweaked but it resulted in file names with double quotes such as
fe_compiler_tests__features__aug_assign@"bit_xor".snapthose file names are illegal on windows and hence also incompatible withcargo packageHow was it fixed?
Tweaked it further so that
fe_compiler_tests__features__aug_assign@"bit_xor".snapbecomesfe_compiler_tests__features__aug_assign@bit_xor.snap