Canonicalize function dependency resolusion - #818
Merged
Conversation
Y-Nak
force-pushed
the
function-dep-order
branch
from
November 23, 2022 14:14
acda8f8 to
5a8e2ad
Compare
Y-Nak
marked this pull request as ready for review
November 23, 2022 14:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong?
The output yul wasn't canonicalized in terms of the output function order due to the usage of
FxHashMapandBTreeSet. This caused non-deterministic byte code output.How was it fixed?
Rewrite them to
IndexMapandIndexSetrespectively.To-Do
OPTIONAL: Update Spec if applicable
Add entry to the release notes (may forgo for trivial changes)
Clean up commit history