Repository navigation
Grow native buffers with realloc - #1983
Merged
Merged
Conversation
`MemVec` and `MemBuffer` grew by allocating the new capacity, copying the elements and freeing the old block. Add `core::ptr::realloc_raw` and `try_realloc_raw`, which growth now uses. Native code resizes with C's `realloc`, which extends a block where it lies or, on glibc, moves a mapped one with `mremap`; EVM memory and WebAssembly modules still allocate and copy. A native resize to at most 1032 bytes still moves through `malloc` and `free`: `realloc` bypasses glibc's per-thread cache, and with it there a fevm transfer took about 250 more instructions. fevm's LOG0 benchmark with 1 KB logs, per transaction: 1.17M to 1.08M instructions and about 390K to 260K user cycles; with glibc's default malloc settings, 956 to 15 page faults and 1.6M to about 30K kernel cycles. A program that replaces `malloc` and `free` must now replace `realloc` too, as the test allocators do.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 11d2cde440
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
`grown_capacity` returned at least `initial` even when `max`, the elements that fit in `MAX_ALLOCATION` bytes, was smaller. For an empty `MemVec` of elements over a quarter of `MAX_ALLOCATION`, such as a 1 GiB array on 32-bit WebAssembly, `try_reserve(1)` asked for four, and the byte size overflowed with `Panic(0x11)` instead of returning `false`. `try_alloc_elems` had rejected that capacity before growth went through `try_realloc_raw`. Clamp the initial capacity to `max`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MemVecandMemBuffergrew by allocating the new capacity, copying the elements and freeing the old block. Growth now goes through newcore::ptr::realloc_rawandtry_realloc_raw. Native code resizes with C'srealloc, which extends a block where it lies or, on glibc, moves a mapped one withmremap. EVM memory and WebAssembly modules still allocate and copy.A native resize to at most 1032 bytes still goes through
mallocandfree, becausereallocbypasses glibc's per-thread cache.fevm's LOG0 benchmark with 1 KB logs, per transaction: 1.17M to 1.08M instructions, about 390K to 260K user cycles, and with glibc's default malloc settings 956 to 15 page faults.
A program that replaces
mallocandfreemust now replacerealloctoo.