Repository navigation
Fix recv arm fields that destructure - #1970
Merged
Merged
Conversation
A recv arm receives a field only when the field's pattern is a plain
name, so `V { t: (x, _) } -> u256 { x }` failed with internal error
16-0004: `x` had no value.
Lowering now binds such a field as `%t` and begins the arm's body with
`let (x, _) = %t`, as a destructured parameter's body does. A refutable
field pattern still reports 8-0153, now at the field, and a name that
another field or an effect binds is still reported. References and
rename search recv arm bodies too, since a field's bindings now lie in
the body.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A recv arm receives a field only when the field's pattern is a plain name, so a destructuring field pattern left its bindings without a value:
Recv arm lowering now binds such a field by a synthetic
%tand begins the arm's body withlet (x, y) = %t, as a destructured parameter's body does, so the runtime boundary only sees plain names.%tbinding.This also unblocks
|bindings in recv fields for #1969.