Repository navigation
Conversation
`core::intrinsic::clear` lowered to one zero store per storage word, so
clearing a large place, such as `SolArray<[u256; 64]>::pop` or removing a
100-word map entry, emitted hundreds of stores. A clear of more than 16
words now lowers to `RuntimeBuiltin::ZeroState { space, slot, len }`,
which Sonatina lowering expands to a loop from `slot` to `slot + len`.
The loop compares with `!=`, so it wraps around the slot space exactly as
the unrolled stores do.
The loop costs about 30 gas per word more than the stores, so narrower
clears stay unrolled.
sbillig
force-pushed
the
perf-clear-loop
branch
from
November 4, 2026 01:20
f852d24 to
0f5f2d7
Compare
Collaborator
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
core::intrinsic::clearzeroed a storage or transient place with one store per word, unrolled, soSolArray<[u256; 64]>::popor removing a 100-wordStorageMapentry emitted hundreds of stores.A clear of more than 16 words now lowers to a
ZeroStateruntime builtin, which Sonatina lowering expands to a loop over the place's slots. The loop stops on!=, so a place that wraps past the top of the slot space clears the same slots the unrolled stores did. The loop costs 23-32 gas per word more than the stores at-O1and-O2, so narrower clears stay unrolled. Memory places are unchanged.A contract that does both of the above shrinks from 1296 to 217 bytes of runtime code; removing a 17-word map entry, from 176 to 89.