Repository navigation
Decode ABI structs directly with budgeted inlining - #1679
Conversation
|
You have reached your Codex usage limits for security reviews. Please try again later. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a1917571a4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
You have reached your Codex usage limits for security reviews. Please try again later. |
Generated ABI struct
decode_fromcurrently inherits a mutable cursor path, including for nested static fields. Generate a direct entry point throughdecode_frame_fromso the complete head is checked once and dynamic-tail bounds propagate to child decoders. Let the backend budget the three direct decoder methods instead of forcing them inline.This carries the two Seaport decoder follow-ups onto the merged #1606 implementation, retaining its hygienic names and shared HIR helpers. Regression cases cover nonzero bases, truncated heads, overflowing positions/tails, and noncanonical static fields.