Skip to content

Decode ABI structs directly with budgeted inlining - #1679

Merged
sbillig merged 3 commits into
masterfrom
perf/seaport-abi-decode
Oct 2, 2026
Merged

sbillig merged 3 commits into
masterfrom
perf/seaport-abi-decode

Conversation

@sbillig

@sbillig sbillig commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator

Generated ABI struct decode_from currently inherits a mutable cursor path, including for nested static fields. Generate a direct entry point through decode_frame_from so the complete head is checked once and dynamic-tail bounds propagate to child decoders. Let the backend budget the three direct decoder methods instead of forcing them inline.

This carries the two Seaport decoder follow-ups onto the merged #1606 implementation, retaining its hygienic names and shared HIR helpers. Regression cases cover nonzero bases, truncated heads, overflowing positions/tails, and noncanonical static fields.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for security reviews. Please try again later.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-01T18:19:17.066921Z da82073 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a1917571a4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/hir/src/core/lower/abi_struct.rs Resolved
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for security reviews. Please try again later.

@sbillig
sbillig merged commit 26ae008 into master Oct 2, 2026
9 checks passed
@sbillig
sbillig deleted the perf/seaport-abi-decode branch October 2, 2026 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant