Repository navigation
Embed created contracts as their standalone bytecode - #1632
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c1970481ab
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The init code a contract deploys with `create<B>`/`create2<B>` differed from the `B.bin` artifact written by `fe build`. All objects of a runtime package were lowered into one Sonatina module, and when B was embedded by a contract in another module it was recompiled inside that contract's module. Module-wide state then changed B's code: symbol conflict resolution renamed B's functions (changing the call-graph emission order), shared helpers got extra callers (changing inliner call counts and dead-argument elimination), and the inliner's module growth budget was shared. CREATE2 addresses derived from keccak(B.bin) therefore did not match the deployed address. Bytecode emission now compiles every object in its own Sonatina module. Objects that a section embeds from another object are compiled first and placed into the embedding section as constant data; code region offset/length builtins for them resolve to that data. The embedded bytes are thus exactly the embedded object's own artifact, and an object's code no longer depends on other contracts in the same package. The trace path keeps compiling one module as before.
cburgdorf
force-pushed
the
fix/embedded-contract-bytecode-consistency
branch
from
September 29, 2026 15:27
c197048 to
edd343a
Compare
sbillig
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The init code a contract deploys with
create<B>/create2<B>differed from theB.binartifact written byfe build. All objects of a runtime package were lowered into one Sonatina module, and when B was embedded by a contract in another module it was recompiled inside that contract's module. Module-wide state then changed B's code: symbol conflict resolution renamed B's functions (changing the call-graph emission order), shared helpers got extra callers (changing inliner call counts and dead-argument elimination), and the inliner's module growth budget was shared. CREATE2 addresses derived from keccak(B.bin) therefore did not match the deployed address.Bytecode emission now compiles every object in its own Sonatina module. Objects that a section embeds from another object are compiled first and placed into the embedding section as constant data; code region offset/length builtins for them resolve to that data. The embedded bytes are thus exactly the embedded object's own artifact, and an object's code no longer depends on other contracts in the same package. Test bytecode and trace emission use the same isolated-object path. Each traced object keeps its own pre/post-optimization identities, and regression tests compare trace hashes and test-embedded init code with standalone build artifacts.