Repository navigation
Encode dynamic tuple returns as a Solidity parameter list - #1625
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
A msg variant returning a tuple such as `-> (DynString, Bytes32, Address)` was encoded like `abi.encode((string,bytes32,address))`, with a leading offset word, and the JSON ABI reported a single `tuple` output. Solidity functions with multiple return values encode them as a parameter list with no outer offset word. Add `AbiSize::IS_PARAM_LIST` (default false, true for tuples) and use it in a new `encode_return_alloc` helper for `ContractHost::return_value`, and in `std::abi::sol::decode_output_at` so typed calls, `decode_returndata` and `CallOutcome::decode` decode tuple returns the same way, mirroring how arguments are already decoded. JSON ABI emission lists one output per tuple element. Single dynamic returns keep the single-root layout, which matches Solidity `returns (T)`; static tuples encode the same bytes as before.
cburgdorf
force-pushed
the
fix/tuple-return-abi-params
branch
from
September 29, 2026 15:09
171f29a to
85984e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A msg variant returning a tuple such as
-> (DynString, Bytes32, Address)was encoded likeabi.encode((string,bytes32,address)), with a leading offset word, and the JSON ABI reported a singletupleoutput. Solidity functions with multiple return values encode them as a parameter list with no outer offset word.Add
AbiSize::IS_PARAM_LIST(default false, true for tuples) and use it in a newencode_return_allochelper forContractHost::return_value, and instd::abi::sol::decode_output_atso typed calls,decode_returndataandCallOutcome::decodedecode tuple returns the same way, mirroring how arguments are already decoded. JSON ABI emission lists one output per tuple element. Single dynamic returns keep the single-root layout, which matches Solidityreturns (T); static tuples encode the same bytes as before.