Skip to content

Diagnose invalid constant types before constant evaluation - #1599

Merged
sbillig merged 2 commits into
masterfrom
fix/reject-oversized-string-constants
Sep 27, 2026
Merged

sbillig merged 2 commits into
masterfrom
fix/reject-oversized-string-constants

Conversation

@cburgdorf

Copy link
Copy Markdown
Collaborator

Diagnose invalid constant declaration types, including oversized inline strings, before constant evaluation instead of reaching a compiler panic.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-25T15:07:10.156190Z e611be7 New commits
🔒 Security Review ✅ Completed 2026-09-25T15:08:45.216530Z e611be7 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 35502252d6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@cburgdorf
cburgdorf requested a review from sbillig September 25, 2026 15:58
@sbillig
sbillig merged commit b32413c into master Sep 27, 2026
9 checks passed
@sbillig
sbillig deleted the fix/reject-oversized-string-constants branch September 27, 2026 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants