Repository navigation
Fix signature hashing for long error and event names - #1592
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
sbillig
approved these changes
Sep 24, 2026
micahscopes
added a commit
that referenced
this pull request
Sep 25, 2026
…ages The `#[error]` desugaring kept its own copies of the `#[event]` signature constant and of the `msg` `AbiSize` and `Encode` impl builders, so each fix had to be made twice: #1516 nested long `TOPIC0` tuples for events only, and #1592 added name chunking to both signature builders and tuple nesting to the `#[error]` one. Build both signature constants with one function, which takes the callee and the constant's name and type, and let errors use the `msg` impl builders, which now take the record type and its fields. The old `#[error]` selector builder and impl builders are deleted. An error's `SELECTOR` now names each field type as `<T as std::abi::SolCompat>::SOL_TYPE`, as `TOPIC0` does. Events and messages lower exactly as before. Add tests that an error with 8 fields reverts with the Solidity selector of its signature, and that the 7- and 8-field selectors evaluate to the `cast sig` values; nothing covered an error signature long enough to need nesting.
This was referenced Sep 25, 2026
micahscopes
added a commit
that referenced
this pull request
Sep 26, 2026
…ages The `#[error]` desugaring kept its own copies of the `#[event]` signature constant and of the `msg` `AbiSize` and `Encode` impl builders, so each fix had to be made twice: #1516 nested long `TOPIC0` tuples for events only, and #1592 added name chunking to both signature builders and tuple nesting to the `#[error]` one. Build both signature constants with one function, which takes the callee and the constant's name and type, and let errors use the `msg` impl builders, which now take the record type and its fields. The old `#[error]` selector builder and impl builders are deleted. An error's `SELECTOR` now names each field type as `<T as std::abi::SolCompat>::SOL_TYPE`, as `TOPIC0` does. Events and messages lower exactly as before. Add tests that an error with 8 fields reverts with the Solidity selector of its signature, and that the 7- and 8-field selectors evaluate to the `cast sig` values; nothing covered an error signature long enough to need nesting.
micahscopes
added a commit
that referenced
this pull request
Sep 27, 2026
…ages The `#[error]` desugaring kept its own copies of the `#[event]` signature constant and of the `msg` `AbiSize` and `Encode` impl builders, so each fix had to be made twice: #1516 nested long `TOPIC0` tuples for events only, and #1592 added name chunking to both signature builders and tuple nesting to the `#[error]` one. Build both signature constants with one function, which takes the callee and the constant's name and type, and let errors use the `msg` impl builders, which now take the record type and its fields. The old `#[error]` selector builder and impl builders are deleted. An error's `SELECTOR` now names each field type as `<T as std::abi::SolCompat>::SOL_TYPE`, as `TOPIC0` does. Events and messages lower exactly as before. Add tests that an error with 8 fields reverts with the Solidity selector of its signature, and that the 7- and 8-field selectors evaluate to the `cast sig` values; nothing covered an error signature long enough to need nesting.
micahscopes
added a commit
that referenced
this pull request
Sep 29, 2026
…ages The `#[error]` desugaring kept its own copies of the `#[event]` signature constant and of the `msg` `AbiSize` and `Encode` impl builders, so each fix had to be made twice: #1516 nested long `TOPIC0` tuples for events only, and #1592 added name chunking to both signature builders and tuple nesting to the `#[error]` one. Build both signature constants with one function, which takes the callee and the constant's name and type, and let errors use the `msg` impl builders, which now take the record type and its fields. The old `#[error]` selector builder and impl builders are deleted. An error's `SELECTOR` now names each field type as `<T as std::abi::SolCompat>::SOL_TYPE`, as `TOPIC0` does. Events and messages lower exactly as before. Add tests that an error with 8 fields reverts with the Solidity selector of its signature, and that the 7- and 8-field selectors evaluate to the `cast sig` values; nothing covered an error signature long enough to need nesting.
micahscopes
added a commit
that referenced
this pull request
Sep 30, 2026
…ages The `#[error]` desugaring kept its own copies of the `#[event]` signature constant and of the `msg` `AbiSize` and `Encode` impl builders, so each fix had to be made twice: #1516 nested long `TOPIC0` tuples for events only, and #1592 added name chunking to both signature builders and tuple nesting to the `#[error]` one. Build both signature constants with one function, which takes the callee and the constant's name and type, and let errors use the `msg` impl builders, which now take the record type and its fields. The old `#[error]` selector builder and impl builders are deleted. An error's `SELECTOR` now names each field type as `<T as std::abi::SolCompat>::SOL_TYPE`, as `TOPIC0` does. Events and messages lower exactly as before. Add tests that an error with 8 fields reverts with the Solidity selector of its signature, and that the 7- and 8-field selectors evaluate to the `cast sig` values; nothing covered an error signature long enough to need nesting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix compilation of errors and events with long names by splitting their generated signature strings into supported chunks.