Skip to content

Lower native raw memory copies through memmove - #1579

Merged
sbillig merged 2 commits into
masterfrom
fevm-pr-native-memory-copy
Sep 25, 2026
Merged

sbillig merged 2 commits into
masterfrom
fevm-pr-native-memory-copy

Conversation

@sbillig

@sbillig sbillig commented Sep 22, 2026 •

Copy link
Copy Markdown
Collaborator

Native core::ptr::copy and copy_raw emit EVM-only MCOPY, causing native builds to fail. Lower these operations to host memmove, preserving overlapping copies and avoiding address access for zero-length copies. Reject addresses and byte ranges that cannot be represented safely by the host before narrowing them, and reserve the host symbol so local Fe helpers remain distinct.

Stacked on #1568 as the final layer of stack #1578. The native runtime support comes from #1565.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-25T00:04:42.951679Z cceb1c4 New commits
🔒 Security Review ✅ Completed 2026-09-25T00:26:36.095219Z cceb1c4 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3cf284a6e7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/codegen/src/function_symbols.rs Resolved
@sbillig
sbillig force-pushed the fevm-pr-native-memory-copy branch from 3cf284a to 0d94bf0 Compare September 22, 2026 23:12
@sbillig
sbillig changed the base branch from fevm-pr-native-runtime to fevm-pr-native-modular September 22, 2026 23:12
@sbillig
sbillig added this pull request to stack #1578 September 22, 2026 23:12
@sbillig
sbillig removed this pull request from stack #1578 September 23, 2026 04:48
@sbillig
sbillig added this pull request to stack #1583 September 23, 2026 04:49
@sbillig
sbillig removed this pull request from stack #1583 September 23, 2026 04:53
@sbillig
sbillig added this pull request to stack #1584 September 23, 2026 04:54
@sbillig
sbillig removed this pull request from stack #1584 September 23, 2026 06:26
@sbillig
sbillig force-pushed the fevm-pr-native-memory-copy branch from 0d94bf0 to a4e93e6 Compare September 23, 2026 06:27
@sbillig
sbillig added this pull request to stack #1588 September 23, 2026 06:28
Base automatically changed from fevm-pr-native-modular to master September 24, 2026 03:32
@sbillig
sbillig force-pushed the fevm-pr-native-memory-copy branch from a4e93e6 to 506bb86 Compare September 24, 2026 04:10
@sbillig

sbillig commented Sep 24, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: d2574bbbc9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review · Automatically triggered

Security review completed. No security issues were found in this pull request.

Reviewed commit: d2574bbbc9

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@sbillig
sbillig force-pushed the fevm-pr-native-memory-copy branch from d2574bb to cceb1c4 Compare September 24, 2026 23:59
@sbillig
sbillig merged commit 8d5ef92 into master Sep 25, 2026
9 checks passed
@sbillig
sbillig deleted the fevm-pr-native-memory-copy branch September 25, 2026 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant