Repository navigation
Decode string literal escapes before semantic lowering - #1563
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e51aebfc70
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
e51aebf to
82c9a35
Compare
82c9a35 to
139b609
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
Several user-facing changes merged after 26.3 were missing release notes entries: - Bugfixes: event ABI `anonymous` flag (#1562), string literal escapes (#1563), effect provider identity (#1564), shared calls on non-Copy fields (#1581), recursive raw pointer types (#1609). - Performance: `DynArray::get` for static elements (#1559), constant string ABI encoding (#1560), compile-time caching (#1617, #1619, #1621). - Native backend features: workspaces, native tests and `std::io` (#1565), process arguments and CPU timing (#1566), `ByteBuffer` (#1580).
String literals currently reach HIR with escape backslashes intact, giving escaped strings incorrect byte lengths and literal contents.
Decode quote, backslash, newline, carriage-return and tab escapes before interning semantic strings. Preserve source spelling in the syntax tree, diagnose invalid escapes at their source spans, and keep malformed literals out of semantic strings during recovery. Literal typing, constant evaluation and code generation share the decoded UTF-8 value.
Render decoded literals with Fe-specific escaping across HIR output and diagnostic hints so printing and reparsing preserves their contents. Align Tree-sitter with the same five supported escapes.