abi optimizations - #1476
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bcbc6be7e7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ac542f8e2a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Adapt eefa434 to the current ABI/SSZ shape by keeping only the applicable inline markers. The hot deposit path now uses Bytes directly instead of the old BytesView inputs, so carry the marker onto the current direct word-load path too. Also mark encode_alloc inline(always), which is the remaining outlined deposit event payload helper that improves bytecode/deploy without increasing deposit call gas. Release differential_deposit after the change: Fe init/runtime 4633/4467, deploy 1715464, deposit calls 80772/66214/46560, total measured call gas 773751. (cherry picked from commit eefa434)
|
latest numbers, after cherry-picking the force-inline commit from #1458: |
cburgdorf
left a comment
cburgdorf
left a comment
There was a problem hiding this comment.
Amazing work. Didn't find anything to worry about. Let's 🚢 it!
2 participants
Per-commit effect, deltas vs parent:
16a607277200338570a35cdaee175fc019462d9e6fb539a32671a488f0482d1f262a469b1b540e02eRegarding 88f0482 (Remove BytesView from ssz/deposit_contract), this is greatly improved by some fe/sonatina aggregate parameter improvements that I'll push up soon.