Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ef6f675853
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| if backend.is_git_cache_path(&path) { | ||
| if matches!(message.kind, ChangeKind::Edit(_)) | ||
| && backend.readonly_warnings.insert(message.uri.clone()) | ||
| { | ||
| let _ = backend.client.clone().show_message(ShowMessageParams { | ||
| typ: MessageType::ERROR, | ||
| message: | ||
| "Git dependency cache files are read-only in the editor; edits are ignored." | ||
| .to_string(), | ||
| }); | ||
| } | ||
| return Ok(()); |
There was a problem hiding this comment.
This early return drops all FileChange events for git cache paths, not just in-editor edits. That means changes coming from didChangeWatchedFiles (e.g., updating a dependency or switching a git revision in the cache) will never refresh the workspace contents, so diagnostics and hover/rename data can stay stale until restart. If the intent is only to block user edits, consider still processing Create/Delete (and possibly Edit(None) from file watchers) while suppressing only Edit(Some(_)) that came from the editor.
Useful? React with 👍 / 👎.
g-r-a-n-t
force-pushed
the
git-cache-read-only
branch
from
ef6f675 to
72d8349
Compare
1 participant
No description provided.