Reverse lazy span and language server goto/hover improvements#1112
Closed
micahscopes wants to merge 15 commits intoargotorg:masterfrom
Closed
Reverse lazy span and language server goto/hover improvements#1112micahscopes wants to merge 15 commits intoargotorg:masterfrom
micahscopes wants to merge 15 commits intoargotorg:masterfrom
Conversation
…ve item paths without visitor; handle super traits and where bounds; update LSP goto/hover and snapshots
…eclarative; synthesis adds MethodCall + segment invariants; update snapshots to reflect improved segment-aware resolution
…olve method call via typed_body.callable_expr; tighten enum variant mapping; update snapshots
…ecks; keep LS declarative; tests green
…re types, enum variant types, type alias and const types; keep end-of-ident hits; LS remains declarative
…m lookup; small helper consolidation
micahscopes
force-pushed
the
reverse-lazy-span
branch
from
11a587f to
d5913a0
Compare
…simplify body context; const goto: resolve consts to item scope; tighten LSP tests/snapshots; remove debug artifacts; ignore logs/session; use hir::collect::find_enclosing_item_at directly
micahscopes
force-pushed
the
reverse-lazy-span
branch
from
d5913a0 to
dda0c1d
Compare
micahscopes
changed the title
Collaborator
Author
|
@sbillig still not quite there but this one is much improved |
Collaborator
Author
|
Not ready to push anything yet but looks like "find all references" and "find all implementations" might fall out pretty naturally from this! (And this is with even fewer lines than are in here now!) |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.