Conversation
sbillig
force-pushed
the
salsa-update
branch
from
70b2b80 to
b2b3a26
Compare
sbillig
force-pushed
the
salsa-update
branch
from
b2b3a26 to
8a4e9be
Compare
Collaborator
Author
|
This has been updated to the latest salsa master, and is ready to merge. Note that I had to replace IndexMap with OrderMap (because the latter implements the Hash trait), which is a light wrapper around IndexMap that changes some behavior to guarantee that the order remains consistent. |
g-r-a-n-t
approved these changes
Feb 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumping the salsa revision again to pick up the latest breaking changes
salsa::Updatetraitderive(salsa::Supertype)allows us to avoid usingsalsa::internedwrapper structs around enums-of-salsa-ids (eg AdtRefId)