fix: Return exit code 1 when fe-driver2 encounters errors#1059
Closed
Turupawn wants to merge 1 commit intoargotorg:fe-v2from
Closed
fix: Return exit code 1 when fe-driver2 encounters errors#1059Turupawn wants to merge 1 commit intoargotorg:fe-v2from
fe-driver2 encounters errors#1059Turupawn wants to merge 1 commit intoargotorg:fe-v2from
Conversation
Collaborator
|
@Turupawn The fe-v2 branch has been merged into master, and is now defunct (I should have deleted it when I merged it in). The change you made is good, but the underlying code has changed. There's a basic |
Contributor
Author
|
Replaced by #1060 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures that
fe-driver2commands exits with code1when errors are detected, preventing silent failures.This changes can help building CI automations like this one that I'm building now.