Open
Conversation
Collaborator
|
Would you mind merging/rebasing master |
favilances
force-pushed
the
locale-timezone-python-chmod
branch
from
0e213d5 to
e673301
Compare
Contributor
Author
|
rebased onto master |
Contributor
|
Why are the bootloader/boot entries part of this pull request? |
This reverts commit e673301.
Torxed
approved these changes
Feb 3, 2026
Collaborator
|
Have you actually tested the code? Can you provide a description as well |
Contributor
|
@Torxed, do you remember adding the chmod that is being changed here? It was added in a59efc4: archinstall/archinstall/lib/installer.py Line 77 in a59efc4 What is it for or why was it added? It doesn't match anything in the installation guide, doubtful it still serves any purpose. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description:
Tests and Checks