gracefully return "undefined" if DMI is not in sysfs#3771
Merged
svartkanin merged 4 commits intoarchlinux:masterfrom Sep 8, 2025
Merged
gracefully return "undefined" if DMI is not in sysfs#3771svartkanin merged 4 commits intoarchlinux:masterfrom
svartkanin merged 4 commits intoarchlinux:masterfrom
Conversation
fixes archlinux#3770, in theory
Collaborator
|
The function shouldn't return some ambiguous string but rather none |
Contributor
Author
|
yeah that works, checked on hardware |
Collaborator
|
You'll need to update the types as well and handle it on the caller side |
Contributor
Author
|
type updated, the one place this function is called seems to not really care about nulltypes (other bits of hardware.py are called in the same way and they may also return null) |
svartkanin
approved these changes
Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description:
Wraps access to the virtual DMI device in a try/except statement to not crash if it doesn't exist.
Tests and Checks