Add type annotations to global storage dictionary#3548
Merged
Torxed merged 1 commit intoarchlinux:masterfrom May 30, 2025
Merged
Add type annotations to global storage dictionary#3548Torxed merged 1 commit intoarchlinux:masterfrom
Torxed merged 1 commit intoarchlinux:masterfrom
Conversation
This will help catch issues like archlinux#3530.
Torxed
reviewed
May 30, 2025
| self.post_base_install: list[Callable] = [] # type: ignore[type-arg] | ||
|
|
||
| # TODO: Figure out which one of these two we'll use.. But currently we're mixing them.. | ||
| storage['session'] = self |
Member
There was a problem hiding this comment.
This might be a breaking change for those scripting their own installations (not everyone uses guided.py or what's referenced in this repo.
This is mainly a note to self so I don't forget to mention that in the release notes.
We should perhaps have gone out with a breaking change notification in the previous release, but it's an easy sed -i "s/storage['session']/storage['installation_session']/g' <file> wherever it's used.
Torxed
approved these changes
May 30, 2025
svartkanin
approved these changes
May 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description:
This will help catch issues like #3530.
Tests and Checks