Skip to content

Conversation

@mas-who
Copy link

@mas-who mas-who commented Nov 13, 2024

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • prevent previous prompt name and content from displaying in the "Add new prompt" modal

  • for system default prompts, prevent edit options to be shown
    Screenshot from 2024-11-13 15-34-52

  • prevent prompt to be saved when the prompt name is empty or clashes with an existing prompt (for both adding and editing prompts)
    Screenshot from 2024-11-13 15-36-00

  • Why was this change needed? (You can also link to an open issue here)
    This PR aims to resolve the bugs reported in 🐛 Bug Report: Last saved Prompt remains on "Add Prompt" #1351

  • Other information:

@vercel
Copy link

vercel bot commented Nov 13, 2024

@mas-who is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@dartpain dartpain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@vercel
Copy link

vercel bot commented Nov 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-gpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2024 5:28pm

@dartpain dartpain merged commit 9deb5ad into arc53:main Nov 14, 2024
6 checks passed
@codecov
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.02%. Comparing base (70f44fc) to head (f6e9f90).
Report is 42 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1435   +/-   ##
=======================================
  Coverage   34.02%   34.02%           
=======================================
  Files          69       69           
  Lines        3377     3403   +26     
=======================================
+ Hits         1149     1158    +9     
- Misses       2228     2245   +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants