chore: update version to 1.7.4 and add experimental warnings#9959
chore: update version to 1.7.4 and add experimental warnings#9959lohanidamodar merged 2 commits intomainfrom
Conversation
…to document endpoints
WalkthroughThis update revises the descriptive label for an API endpoint to "Upsert documents," increments the stable application version constant from 1.7.3 to 1.7.4, adds the new version to the migration version mapping, and refines test code for expiration time formatting in account email validation. No changes to logic, control flow, or exported entity signatures were made. Changes
Possibly related PRs
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Security Scan Results for PRDocker Image Scan Results
Source Code Scan Results🎉 No vulnerabilities found! |
commit: |
✨ Benchmark results
⚡ Benchmark Comparison
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (1)
tests/e2e/Services/Account/AccountCustomClientTest.php (1)
1087-1087: Consistent implementation with verification email test.This change mirrors the improvement made in the verification email test (line 784), ensuring consistent expiration time validation across both verification and recovery email workflows.
The same refactoring suggestion from line 784 applies here - consider extracting the common DateTime formatting logic to reduce code duplication.
🧹 Nitpick comments (1)
tests/e2e/Services/Account/AccountCustomClientTest.php (1)
784-784: LGTM! Improved timestamp validation with microsecond precision.The DateTime formatting with
'Y-m-d\TH:i:s.v'pattern provides better precision for expiration time validation in the verification email. The logic is correct and follows proper DateTime handling practices.Consider extracting the common DateTime formatting logic since it's duplicated on line 1087:
private function formatExpireTimeForEmail(string $expireTime): string { return urlencode((new \DateTime($expireTime))->format('Y-m-d\TH:i:s.v')); }Then use it in both locations:
-$expireTime = strpos($lastEmail['text'], 'expire=' . urlencode((new \DateTime($response['body']['expire']))->format('Y-m-d\TH:i:s.v')), 0); +$expireTime = strpos($lastEmail['text'], 'expire=' . $this->formatExpireTimeForEmail($response['body']['expire']), 0);
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
tests/e2e/Services/Account/AccountCustomClientTest.php(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Setup & Build Appwrite Image
- GitHub Check: scan
chore: update version to 1.7.4 and add experimental warnings
3 participants
What does this PR do?
Add experimental feature warnings to bulk and upsert document methods.
Test Plan
Related PRs and Issues
Checklist
Summary by CodeRabbit