Skip to content

fix(gif preview): enable resource limits#9940

Merged
christyjacob4 merged 1 commit into1.7.xfrom
PLA-2950
Jun 3, 2025
Merged

fix(gif preview): enable resource limits#9940
christyjacob4 merged 1 commit into1.7.xfrom
PLA-2950

Conversation

@basert
Copy link
Copy Markdown
Contributor

@basert basert commented May 30, 2025 •
edited by coderabbitai bot
Loading

Needs: utopia-php/image#42

Summary by CodeRabbit

  • New Features
    • Added support for GIF image files as accepted input and output formats.
    • Introduced configurable memory usage limits for image processing, with a default setting and support for environment variable overrides.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented May 30, 2025 •
edited
Loading

Walkthrough

The changes update configuration files to add support for GIF image formats in both input and output MIME type mappings. A new configuration file introduces a resource limit for image processing memory, which is initialized during configuration setup. The initialization script is updated to include this new resource limit configuration.

Changes

File(s) Change Summary
app/config/storage/inputs.php,
app/config/storage/outputs.php		 Added "gif" => "image/gif" to input and output MIME type mappings.
app/config/storage/resource_limits.php New file sets image processing memory limit using an environment variable or default value.
app/init/configs.php Added require_once to include resource_limits.php before loading other configs.

Poem

A hop and a skip, GIFs join the parade,
In configs and limits, new rules are laid.
Memory’s measured, resources tight,
Now bunnies process images right.
With every byte and every frame,
The code leaps forward—never the same!
🐰✨

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e79c89c and 584ca30.

⛔ Files ignored due to path filters (1)
  • composer.lock is excluded by !**/*.lock
📒 Files selected for processing (4)
  • app/config/storage/inputs.php (1 hunks)
  • app/config/storage/outputs.php (1 hunks)
  • app/config/storage/resource_limits.php (1 hunks)
  • app/init/configs.php (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (4)
  • app/init/configs.php
  • app/config/storage/inputs.php
  • app/config/storage/outputs.php
  • app/config/storage/resource_limits.php
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Setup & Build Appwrite Image
  • GitHub Check: Setup & Build Appwrite Image
  • GitHub Check: scan
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link
Copy Markdown

github-actions bot commented May 30, 2025 •
edited
Loading

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
binutils 2.42-r0 CVE-2025-0840 HIGH
libexpat 2.6.4-r0 CVE-2024-8176 HIGH
libxml2 2.12.7-r0 CVE-2024-56171 HIGH
libxml2 2.12.7-r0 CVE-2025-24928 HIGH
libxml2 2.12.7-r0 CVE-2025-27113 HIGH
libxml2 2.12.7-r0 CVE-2025-32414 HIGH
libxml2 2.12.7-r0 CVE-2025-32415 HIGH
sqlite-libs 3.45.3-r1 CVE-2025-29087 HIGH
xz 5.6.2-r0 CVE-2025-31115 HIGH
xz-libs 5.6.2-r0 CVE-2025-31115 HIGH
golang.org/x/crypto v0.31.0 CVE-2025-22869 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

coderabbitai[bot]
coderabbitai bot reviewed May 30, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
app/config/storage/outputs.php (1)

11-11: Add GIF to accepted output MIME types
Mapping "gif" => "image/gif" completes the round-trip support for GIFs. Consider updating documentation or .env.example to highlight GIF support and the new _APP_IMAGES_RESOURCE_LIMIT_MEMORY variable.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7e4a3bb and 6c18d76.

⛔ Files ignored due to path filters (1)
  • composer.lock is excluded by !**/*.lock
📒 Files selected for processing (5)
  • app/config/storage/inputs.php (1 hunks)
  • app/config/storage/outputs.php (1 hunks)
  • app/config/storage/resource_limits.php (1 hunks)
  • app/init/configs.php (1 hunks)
  • composer.json (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Setup & Build Appwrite Image
  • GitHub Check: Setup & Build Appwrite Image
  • GitHub Check: scan
🔇 Additional comments (4)
app/config/storage/resource_limits.php (1)

1-7: Set memory resource limits early
The new config correctly initializes image processing memory limits using an environment variable with a 64 MB fallback. Casting via intval ensures an integer is passed. Great job integrating this early in the stack.

app/init/configs.php (1)

5-5: Load resource limits before other configs
Including resource_limits.php via require_once ensures memory limits are applied prior to other image-related configurations. Please verify the autoloader is in place before this include to avoid class-not-found errors for Utopia\Image and Utopia\System.

app/config/storage/inputs.php (1)

10-10: Add GIF to accepted input MIME types
Support for GIF inputs is now enabled by mapping "gif" => "image/gif". This aligns with the updated outputs and enables processing of GIF images.

composer.json (1)

61-61: Pin utopia-php/image to development branch
Switching to dev-PLA-2950 as 0.8.0 lets you leverage the resource-limit feature. Ensure your composer.json stability settings permit this alias, and run a dry-run dependency update to confirm it resolves correctly.

@github-actions
Copy link
Copy Markdown

github-actions bot commented May 30, 2025 •
edited
Loading

✨ Benchmark results

  • Requests per second: 914
  • Requests with 200 status code: 164,533
  • P99 latency: 0.207181181

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 914 1,116
200 164,533 200,856
P99 0.207181181 0.169361015

@basert basert force-pushed the PLA-2950 branch 5 times, most recently from e79c89c to 8d43e36 Compare June 3, 2025 08:29
@christyjacob4 christyjacob4 merged commit b47ab90 into 1.7.x Jun 3, 2025
38 checks passed
@stnguyen90 stnguyen90 deleted the PLA-2950 branch June 12, 2025 18:59
@stnguyen90 stnguyen90 mentioned this pull request Jun 12, 2025
Closed
2 tasks
@stnguyen90 stnguyen90 linked an issue Jun 12, 2025 that may be closed by this pull request
🐛 Bug Report: Storage getFilePreview for GIF file returns an icon #9984
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@christyjacob4 christyjacob4 christyjacob4 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: Storage getFilePreview for GIF file returns an icon

2 participants

@basert @christyjacob4