Skip to content

Revert#9898

Merged
abnegate merged 3 commits into1.7.xfrom
chore-revert
May 26, 2025
Merged

Revert#9898
abnegate merged 3 commits into1.7.xfrom
chore-revert

Conversation

@abnegate
Copy link
Copy Markdown
Member

@abnegate abnegate commented May 26, 2025 •
edited by coderabbitai bot
Loading

What does this PR do?

(Provide a description of what this PR does and why it's needed.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)

Related PRs and Issues

  • (Related PR or issue)

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

Summary by CodeRabbit

  • Bug Fixes
    • Removed plan-based restrictions and minimum size checks for encrypted string attributes in database operations.
  • Refactor
    • Simplified attribute creation and update logic by eliminating plan validation and related encryption constraints.
  • Tests
    • Updated and streamlined tests to reflect removal of encryption size validation and plan-based checks for string attributes.
  • Chores
    • Removed a constant defining minimum encryption size from the constants configuration.
  • Refactor
    • Refined attribute filtering logic to only process relationship-type attributes, removing string-type specific handling.
  • Style
    • Eliminated validation rules for the 'encrypt' property in attribute classes.
  • Chores
    • Updated SDK generator dependency to a newer version in the project configuration.

abnegate added 2 commits May 26, 2025 21:37
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented May 26, 2025 •
edited
Loading

Walkthrough

This change removes plan-based restrictions and minimum size validation for encrypted string attributes in database APIs. It eliminates related constants, validation logic, and test assertions, simplifying attribute creation and update flows. The handling of the 'encrypt' property is streamlined, and associated test cases are updated to reflect the absence of these constraints.

Changes

File(s) Change Summary
app/controllers/api/databases.php Removed plan-based encryption restrictions and minimum size validation from attribute creation/update logic.
app/init/constants.php Deleted the APP_DATABASE_ENCRYPT_SIZE_MIN constant.
app/init/database/filters.php Refactored attribute handling: removed logic for 'encrypt' on string attributes, simplified to relationship only.
src/Appwrite/Utopia/Response/Model/AttributeString.php Removed the validation rule for the 'encrypt' property in the attribute model.
tests/e2e/Services/Databases/DatabasesBase.php Added assertion to verify 'encrypt' property is false for string attributes.
tests/e2e/Services/Databases/DatabasesCustomServerTest.php Removed tests and assertions related to encrypted attribute size validation and 'encrypt' property checks.

Possibly related PRs

Poem

In the land where databases hop and play,
Plan checks and size rules have hopped away.
Encryption flows free, no more minimum size,
Attributes are lighter—what a pleasant surprise!
The code is now simple, the tests are at ease,
A bunny’s job done, with carrots and peace. 🥕

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ab97b7c and c7c9e05.

⛔ Files ignored due to path filters (1)
  • composer.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • composer.json (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Setup & Build Appwrite Image
  • GitHub Check: Setup & Build Appwrite Image
  • GitHub Check: scan
🔇 Additional comments (1)
composer.json (1)

89-89:

Details

❓ Verification inconclusive

Verify sdk-generator version bump
We've updated the require-dev constraint from "0.40.*" to "0.41.*". Please confirm that version 0.41.* is available on Packagist and does not introduce breaking changes to the SDK generator workflow.

🏁 Script executed:

#!/bin/bash
# Check availability of appwrite/sdk-generator 0.41.* on Packagist
curl -s https://repo.packagist.org/p2/appwrite/sdk-generator.json | jq '.packages["appwrite/sdk-generator"][] | select(.version | startswith("0.41"))'

Length of output: 1556

SDK-Generator version bump verified on Packagist
We’ve confirmed that appwrite/sdk-generator version 0.41.0 is available. Please review the official release notes or CHANGELOG (https://github.com/appwrite/sdk-generator/releases/tag/0.41.0) to ensure there are no breaking changes affecting your SDK generation workflow.

• File: composer.json (line 89)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link
Copy Markdown

github-actions bot commented May 26, 2025 •
edited
Loading

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
binutils 2.42-r0 CVE-2025-0840 HIGH
libexpat 2.6.4-r0 CVE-2024-8176 HIGH
libxml2 2.12.7-r0 CVE-2024-56171 HIGH
libxml2 2.12.7-r0 CVE-2025-24928 HIGH
libxml2 2.12.7-r0 CVE-2025-27113 HIGH
libxml2 2.12.7-r0 CVE-2025-32414 HIGH
libxml2 2.12.7-r0 CVE-2025-32415 HIGH
sqlite-libs 3.45.3-r1 CVE-2025-29087 HIGH
xz 5.6.2-r0 CVE-2025-31115 HIGH
xz-libs 5.6.2-r0 CVE-2025-31115 HIGH
golang.org/x/crypto v0.31.0 CVE-2025-22869 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

@github-actions
Copy link
Copy Markdown

github-actions bot commented May 26, 2025 •
edited
Loading

✨ Benchmark results

  • Requests per second: 933
  • Requests with 200 status code: 168,052
  • P99 latency: 0.202614295

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 933 1,170
200 168,052 210,696
P99 0.202614295 0.159449332

@abnegate abnegate merged commit 3f9b4e9 into 1.7.x May 26, 2025
38 checks passed
@abnegate abnegate deleted the chore-revert branch May 26, 2025 10:05
@coderabbitai coderabbitai bot mentioned this pull request Jun 11, 2025
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Meldiron Meldiron Meldiron approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@abnegate @Meldiron