Skip to content

chore: use unique filename for health check#9842

Merged
stnguyen90 merged 1 commit into1.7.xfrom
pla-2914
May 23, 2025
Merged

chore: use unique filename for health check#9842
stnguyen90 merged 1 commit into1.7.xfrom
pla-2914

Conversation

@ChiragAgg5k
Copy link
Copy Markdown
Member

@ChiragAgg5k ChiragAgg5k commented May 21, 2025 •
edited by stnguyen90
Loading

What does this PR do?

uses unique filenames for healthcheck to ensure multiple calls to the health endpoint don't conflict with eachother.

Test Plan

Related PRs and Issues

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

Summary by CodeRabbit

  • Bug Fixes
    • Improved reliability of storage device health checks by using uniquely named temporary files for each check.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented May 21, 2025 •
edited
Loading

Walkthrough

The health check logic for storage devices was updated to use a uniquely generated temporary filename for each test operation, replacing the previous use of a fixed filename. This change affects how the system writes, reads, and deletes the health check file on each device, while keeping error handling unchanged.

Changes

File(s) Change Summary
app/controllers/api/health.php Modified health check to generate and use a unique temporary filename for each device check.

Poem

In the warren, checks abound,
Each device gets a file that's sound.
No more clashes, names unique,
Health checks now are at their peak!
With every hop, a safer test,
Storage bunnies do their best.
🐇✨

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.

Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 30th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between e9d0462 and fe54194.

📒 Files selected for processing (1)
  • app/controllers/api/health.php (1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
app/controllers/api/health.php (1)
src/Appwrite/Extend/Exception.php (1)
  • Exception (7-406)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Setup & Build Appwrite Image
  • GitHub Check: Setup & Build Appwrite Image
  • GitHub Check: scan
🔇 Additional comments (1)
app/controllers/api/health.php (1)

854-869: Good improvement: Using unique filenames for health checks

This change enhances the health check process by generating unique filenames rather than using a fixed name. This prevents potential collisions or interference between concurrent health checks and eliminates issues with leftover test files from previous checks.

The implementation correctly:

  • Generates a unique filename with entropy
  • Uses this filename consistently across write, read, and delete operations
  • Maintains the existing error handling pattern
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link
Copy Markdown

github-actions bot commented May 21, 2025

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
binutils 2.42-r0 CVE-2025-0840 HIGH
libexpat 2.6.4-r0 CVE-2024-8176 HIGH
libxml2 2.12.7-r0 CVE-2024-56171 HIGH
libxml2 2.12.7-r0 CVE-2025-24928 HIGH
libxml2 2.12.7-r0 CVE-2025-27113 HIGH
libxml2 2.12.7-r0 CVE-2025-32414 HIGH
libxml2 2.12.7-r0 CVE-2025-32415 HIGH
sqlite-libs 3.45.3-r1 CVE-2025-29087 HIGH
xz 5.6.2-r0 CVE-2025-31115 HIGH
xz-libs 5.6.2-r0 CVE-2025-31115 HIGH
golang.org/x/crypto v0.31.0 CVE-2025-22869 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

@ChiragAgg5k ChiragAgg5k requested a review from stnguyen90 May 21, 2025 07:36
@github-actions
Copy link
Copy Markdown

github-actions bot commented May 21, 2025

✨ Benchmark results

  • Requests per second: 910
  • Requests with 200 status code: 163,763
  • P99 latency: 0.203225774

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 910 1,148
200 163,763 206,672
P99 0.203225774 0.162267025

@stnguyen90 stnguyen90 merged commit 6526e8d into 1.7.x May 23, 2025
38 checks passed
@coderabbitai coderabbitai bot mentioned this pull request May 23, 2025
Merged
2 tasks
ChiragAgg5k added a commit that referenced this pull request Jun 11, 2025
@ChiragAgg5k
chore: restore unique filename for health check #9842
fc41f34
ChiragAgg5k added a commit that referenced this pull request Jun 11, 2025
@ChiragAgg5k
chore: restore unique filename for health check #9842
8518949
@stnguyen90 stnguyen90 mentioned this pull request Jun 11, 2025
Merged
2 tasks
stnguyen90 added a commit that referenced this pull request Jun 11, 2025
@stnguyen90
Merge pull request #9993 from appwrite/re-revert-pla-2914
c14d40c 
chore: restore unique filename for health check #9842
@loks0n loks0n mentioned this pull request Jun 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stnguyen90 stnguyen90 stnguyen90 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ChiragAgg5k @stnguyen90